Add support for Maryland (24), Indiana (25), Kentucky (26), Rhode Island (27)#104
Open
chuff wants to merge 1 commit into
Open
Add support for Maryland (24), Indiana (25), Kentucky (26), Rhode Island (27)#104chuff wants to merge 1 commit into
chuff wants to merge 1 commit into
Conversation
…and (27) Re-implements the four new MSPA state sections for the 4.X architecture (declarative FieldKey enums + Base64Segment), rather than porting the segment-class-based master implementation. - US-MD (24): Core + GPC subsection, via AbstractUsSectionWithGpc. - US-IN (25), US-KY (26), US-RI (27): Core + optional "Sensitive Data Consents" subsection. Adds AbstractUsSectionWithSensitiveDataConsent, a sibling of AbstractUsSectionWithGpc for that pattern. Each section follows the latest MSPA spec field layout (MspaVersion, MspaCoveredTransaction, MspaMode, ... first). Registered in GppModel. Output is identical to the master-based PR (IABTechLab#103): the per-section tests assert the same encoded strings (MD BQAA.QA / BVVU.YA; IN/KY/RI BQAA.AAA / BVVV.kkk) and round-trip them back. mvn test: 368 tests, 0 failures; spotless:check clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the four new MSPA state sections, implemented for the 4.X architecture (declarative
FieldKeyenums +Base64Segment) rather than ported from the segment-class style onmaster.AbstractUsSectionWithGpc.AbstractUsSectionWithSensitiveDataConsent, a sibling ofAbstractUsSectionWithGpcfor that core+optional-segment pattern.Each section uses the latest MSPA spec field layout (
MspaVersion,MspaCoveredTransaction,MspaMode, … first; MD has noKnownChildSensitiveDataConsents/SensitiveDataProcessing; IN/KY/RI carryKnownChildSensitiveDataConsentsin core andSensitiveDataProcessingas anN-Bitfield(2,8)in the second subsection). Sections are registered inGppModel.This targets
4.Xper discussion, superseding themaster-based #103 for the 4.X line.Output consistency
Verified identical to the
master-based implementation: the per-section tests assert the same encoded strings produced there and round-trip them —BQAA.QA, all-setBVVU.YABQAA.AAA, all-setBVVV.kkkTest plan
mvn test— 368 tests, 0 failuresmvn spotless:check— clean🤖 Generated with Claude Code